ZMZ91 commented on a change in pull request #10884:
URL: https://github.com/apache/arrow/pull/10884#discussion_r779969230



##########
File path: cpp/src/gandiva/llvm_generator.cc
##########
@@ -170,6 +170,9 @@ llvm::Value* LLVMGenerator::GetDataReference(llvm::Value* 
arg_addrs, int idx,
   llvm::Value* load = LoadVectorAtIndex(arg_addrs, idx, name);

Review comment:
       Thanks @rkavanap. Could you involve some guy familiar with dremio and 
help review this? If dremio might update code correspondingly, I think the 
change should be small.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to