Dandandan commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780335960
##########
File path: datafusion/src/physical_plan/aggregates.rs
##########
@@ -212,6 +222,26 @@ pub fn create_aggregate_expr(
"AVG(DISTINCT) aggregations are not available".to_string(),
));
}
+ (AggregateFunction::Variance, false) =>
Arc::new(expressions::Variance::new(
+ coerced_phy_exprs[0].clone(),
+ name,
+ return_type,
+ )),
+ (AggregateFunction::Variance, true) => {
+ return Err(DataFusionError::NotImplemented(
+ "VARIANCE(DISTINCT) aggregations are not
available".to_string(),
+ ));
+ }
+ (AggregateFunction::Stddev, false) =>
Arc::new(expressions::Stddev::new(
+ coerced_phy_exprs[0].clone(),
+ name,
+ return_type,
+ )),
+ (AggregateFunction::Stddev, true) => {
+ return Err(DataFusionError::NotImplemented(
+ "VARIANCE(DISTINCT) aggregations are not
available".to_string(),
Review comment:
```suggestion
"STDDEV(DISTINCT) aggregations are not
available".to_string(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
