Igosuki commented on pull request #68: URL: https://github.com/apache/arrow-datafusion/pull/68#issuecomment-1007923402
No worries, I was just eager to try out the potential improvements and learn the new API ! Le sam. 8 janv. 2022 à 04:26, QP Hou ***@***.***> a écrit : > Apologize for the late reply, still catching up to all the goodness > happened during the break. I should have communicated this better to save > @Igosuki <https://github.com/Igosuki> some work :( But really impressive > result, thank you for doing the benchmark! > > I have squashed our latest round of merge fixes into a single commit to > keep things clean and pushed it to this PR. What is missing right now from > my point of view is migrating the python crate and avro. @Igosuki > <https://github.com/Igosuki> do you mind sending your avro changes to my > branch at https://github.com/houqp/arrow-datafusion/tree/arrow2_merge so > I can merge it into this PR? After that I think this PR is ready for a > formal review with another round of quick master merge to pick up the > removal of the python binding. > > @alamb <https://github.com/alamb> to answer your question, I think the > arrow2 branch is ready to be tested more broadly now. I feel like we should > merge this either to master or to an official arrow2 branch soon without > waiting for arrow2 1.x release, which is probably going to take a while. > The API in arrow2 is still evolving fast right now (in a good direction), > so I don't see it getting stablized any time soon. For example, it just > recently removed the RecoardBatch abstraction entirely, which also aligns > with our goal to come up with our own recordbatch abstraction in > datafusion: #1248 <https://github.com/apache/arrow-datafusion/issues/1248> > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-datafusion/pull/68#issuecomment-1007877042>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADDFBREKA2MO6LSGD7KP43UU6VH3ANCNFSM43RKTGGA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
