thisisnic commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780125202
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -382,6 +382,15 @@ test_that("extract epiweek from timestamp", {
)
})
+test_that("extract week from timestamp", {
Review comment:
This looks good! Would you mind also adding a test for "extract week
from date"?
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, options = list(count_from_zero =
FALSE, week_start = week_start))
})
+ register_binding("week", function(x) {
+ (call_binding("yday", x) - 1) %/% 7 + 1
+ })
+
Review comment:
This approach makes sense, although I think there might be a C++ compute
function which can do this instead of calculating it manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
