Ted-Jiang commented on issue #1531:
URL: 
https://github.com/apache/arrow-datafusion/issues/1531#issuecomment-1008574403


   > Thanks @Ted-Jiang for the deepdive, if you look at the comment above the 
tokio spawn line you linked, it also mentioned we should only run a single 
loop. Perhaps we should first look into whether it is expected to have 11 
scheduler servers created in the first place in the same process.
   
   Thanks @houqp  for your reply, in my opinion:
   
https://github.com/apache/arrow-datafusion/blob/d6d90e93117293adfa7aa6f4a93bd796665c28a3/ballista/rust/scheduler/src/main.rs#L67
   send  a closure to `make_service_fn`, each request will call 
`SchedulerServer::new` then start a synchronize_job_status_loop
   
   i think it should extract  `SchedulerServer::new` before start server
   
https://github.com/apache/arrow-datafusion/blob/d6d90e93117293adfa7aa6f4a93bd796665c28a3/ballista/rust/scheduler/src/main.rs#L66
   send copy to each request, is this ok ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to