davisusanibar commented on a change in pull request #113:
URL: https://github.com/apache/arrow-cookbook/pull/113#discussion_r781610506
##########
File path: Makefile
##########
@@ -1,7 +1,7 @@
all: html
-html: py r
+html: py r j
Review comment:
Updated
> It might be worth writing a custom Sphinx extension like we did for C++
for these examples, especially since we're apparently duplicating code between
examples and actual Java code.
>
> For instance, maybe we could have something that accepts a file containing
Java code, and the block is a series of JShell statements. Then for a docs
build, it would just render the Java code and the JShell session. For a test
build, it would run the Java code, then run the JShell statements, and check
that the output matches what's expected.
In this case >jshell offer a "/edit" command when we could paste all our
util code to define methods that then could be used for cookbook recipes or run
all the cookbook code and then only validate output for /edit code and also
/reset to do it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
