houqp commented on a change in pull request #1542:
URL: https://github.com/apache/arrow-datafusion/pull/1542#discussion_r781703572
##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -565,7 +565,17 @@ pub trait Accumulator: Send + Sync + Debug {
// of two values, sum and n.
fn state(&self) -> Result<Vec<ScalarValue>>;
- /// updates the accumulator's state from a vector of scalars.
+ /// updates the accumulator's state from a vector of scalars
+ /// (called by default implementation of [`update_batch`])
+ ///
+ /// Note: this method is the often the simplest to implement and
Review comment:
```suggestion
/// Note: this method is often the simplest to implement and
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
