tustvold commented on a change in pull request #1154:
URL: https://github.com/apache/arrow-rs/pull/1154#discussion_r782006587
##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -100,6 +100,26 @@ pub trait ArrayReader {
fn get_rep_levels(&self) -> Option<&[i16]>;
}
+/// A collection of row groups
+pub trait RowGroupCollection {
+ /// Get schema of parquet file.
+ fn schema(&self) -> Result<SchemaDescPtr>;
+
+ /// Returns an iterator over the column chunks for particular column
+ fn column_chunks(&self, i: usize) -> Result<Box<dyn PageIterator>>;
+}
+
+impl RowGroupCollection for Arc<dyn FileReader> {
Review comment:
This does mean we have double dynamic dispatch, given these methods are
called a couple of times per-file I'm inclined to consider this largely
irrelevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
