tustvold commented on a change in pull request #1041:
URL: https://github.com/apache/arrow-rs/pull/1041#discussion_r782251158
##########
File path: parquet/src/data_type.rs
##########
@@ -1033,21 +1032,6 @@ pub(crate) mod private {
self
}
}
-
- /// A marker trait for [`DataType`] with a [scalar] physical type
Review comment:
> impl ScalarDataType for i16
In short, no... `DataType` is tightly coupled with what it means to be a
physical parquet type, which i16 is not
> If you you need to remove this code, then we should probably reopen the
original ticket
It is an alternative way of fixing that ticket. Rather than constraining `T:
DataType` we constrain `T::T`. The two approaches are equivalent, but the
latter allows implementing the marker trait for types that don't have a
corresponding `DataType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
