alamb opened a new issue #1549: URL: https://github.com/apache/arrow-datafusion/issues/1549
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.** It is very non obvious that either one or the other of `Accumulator::update` or `Accumulator::update_batch` are called. This results in unfortunate things like https://github.com/apache/arrow-datafusion/pull/1525 (implementation in terms of `ScalarValue`) only then to be followed by https://github.com/apache/arrow-datafusion/issues/1546 (implementation in terms of `Array`) In addition, `update_batch` and `merge_batch` will always be the most performant, so they should always be what is implemented. The same issue applies to `Accumulator::merge` and `Accumulator::merge_batch` I tried making this clearer in the docs via https://github.com/apache/arrow-datafusion/pull/1542 **Describe the solution you'd like** I think a clearer thing to do would be to remove `update` and `merge` entirely from the traits and ensure the examples are clear to keep the barrier to entry as low as possible. **Additional context** See additional context on https://github.com/apache/arrow-datafusion/pull/1547#pullrequestreview-849686382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
