jvictorhuguenin commented on a change in pull request #10425:
URL: https://github.com/apache/arrow/pull/10425#discussion_r782659277
##########
File path: cpp/src/gandiva/precompiled/timestamp_arithmetic.cc
##########
@@ -172,6 +172,57 @@ TIMESTAMP_DIFF(timestamp)
return millis + TO_MILLIS * static_cast<gdv_##TYPE>(count); \
}
+#define ADD_DAY_TIME_INTERVAL_TO_DATE_TYPES(TYPE, NAME, TO_MILLIS) \
+ FORCE_INLINE \
+ gdv_##TYPE NAME##_day_time_interval_##TYPE(gdv_##TYPE millis, \
+ gdv_day_time_interval count) { \
+ gdv_int64 day_interval_days = extractDay_daytimeinterval(count); \
+ gdv_int64 day_interval_millis = extractMillis_daytimeinterval(count); \
+ return static_cast<gdv_##TYPE>(millis) + \
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]