jhorstmann commented on pull request #1048: URL: https://github.com/apache/arrow-rs/pull/1048#issuecomment-1011009045
I changed to using the `is_ordered` flag as initially proposed and a `fn as_ordered(&self, is_ordered: bool) -> Self` that would return a DictionaryArray with the flag set (without actually sorting or checking the ordering). Now testing this in our engine I realized that instead of `as_ordered` for partitioning I could also just get the keys array directly and partition on that, `as_ordered` doesn't really simplify that part of the code. So this code would only become useful when we also add a way to *efficiently* transform a DictionaryArray to being sorted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
