edponce commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r783115242
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -316,6 +316,21 @@ struct ARROW_EXPORT CompareOptions {
enum CompareOperator op;
};
+enum class BetweenMode : int8_t {
+ LESS_EQUAL_LESS_EQUAL,
+ LESS_EQUAL_LESS,
+ LESS_LESS_EQUAL,
+ LESS_LESS,
+};
Review comment:
@lidavidm is correct. There should only be one:
```c++
class BetweenOptions {
public:
enum Inclusive {
BOTH,
// ...
};
// ...
};
```
in global space, so that it can be used by both `between` and
`not_between`. Something important to note is that[ there is a discussion in
JIRA on whether "not_between" should
exist](https://issues.apache.org/jira/browse/ARROW-15223).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
