jonkeane commented on a change in pull request #12133:
URL: https://github.com/apache/arrow/pull/12133#discussion_r783479690
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -397,6 +397,59 @@ test_that("Partitioning inference", {
)
})
+test_that("Specifying partitioning when hive_style", {
+ expected_schema <- open_dataset(hive_dir)$schema
+
+ # If string and names match hive partition names, it's accepted silently
+ ds_with_chr <- open_dataset(hive_dir, partitioning = c("group", "other"))
+ expect_equal(ds_with_chr$schema, expected_schema)
Review comment:
Do we want to test that the contents of the partitioning columns _don't_
have the partitioning bits in them too? Or maybe those are tested elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
