nealrichardson commented on a change in pull request #12133:
URL: https://github.com/apache/arrow/pull/12133#discussion_r783506708
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -397,6 +397,59 @@ test_that("Partitioning inference", {
)
})
+test_that("Specifying partitioning when hive_style", {
+ expected_schema <- open_dataset(hive_dir)$schema
+
+ # If string and names match hive partition names, it's accepted silently
+ ds_with_chr <- open_dataset(hive_dir, partitioning = c("group", "other"))
+ expect_equal(ds_with_chr$schema, expected_schema)
Review comment:
It's covered here in that `group` wouldn't be `int32` (what we detect,
which is tested elsewhere), it would be `string`. This test fails on master,
and the old behavior is still possible with `hive_style = FALSE`, which is
tested on L442.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
