pitrou commented on a change in pull request #12076:
URL: https://github.com/apache/arrow/pull/12076#discussion_r783802323
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -1027,6 +1266,15 @@ cdef class _ScalarAggregateOptions(FunctionOptions):
class ScalarAggregateOptions(_ScalarAggregateOptions):
+ __doc__ = f"""
+ Options for scalar aggregations.
+
+ Parameters
+ ----------
+ {_skip_nulls_doc()}
Review comment:
> someone might think that it's reasonable for example to add one more
option in _skip_nulls_doc() causing a wrong option to be added to one of the
Option classes using that function.
Hmm, I don't understand. Why would someone add an option there?
The entire purpose of `_skip_nulls_doc()` is to factor the documentation for
a single _option `skip_nulls`. It's not documenting function named "skip_nulls"
to which people would add other options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
