pitrou commented on a change in pull request #12134:
URL: https://github.com/apache/arrow/pull/12134#discussion_r783849620
##########
File path: cpp/src/arrow/util/basic_decimal.cc
##########
@@ -1391,4 +1347,8 @@ BasicDecimal256 operator/(const BasicDecimal256& left,
const BasicDecimal256& ri
return result;
}
+// Explicitly instantiate template base class, for DLL linking on Windows
Review comment:
It should, though that's not the goal here :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]