davisusanibar commented on a change in pull request #113:
URL: https://github.com/apache/arrow-cookbook/pull/113#discussion_r784012184
##########
File path: Makefile
##########
@@ -13,6 +13,7 @@ help:
@echo "make test Test cookbook for all platforms."
@echo "make py Build the Cookbook for Python only."
@echo "make r Build the Cookbook for R only."
+ @echo "make java Build the Cookbook for Java only."
Review comment:
In our case to cover testing code documentation we have two options:
1. Create java cookbook inside of java unit test and run "mvn test" before
to excute "make java"
2. Continue with jshell and create a custom tester output validator (extend
SphinxDirective) as the same c++ do with
[c-extension](https://github.com/apache/arrow-cookbook/blob/main/cpp/ext/recipeext.py)
I could suggest that jshell offer fast initiation/testing arrow java code
immediately but it needed to create a custom sphinx directive
Java unit test code is the more easy way but we could lose jshell power
My proposal is to continue with jshell and create another ticket to create a
custom sphinx directive (time estimation: not idea at this moment)
Please let me know if this make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
