edponce commented on a change in pull request #12147:
URL: https://github.com/apache/arrow/pull/12147#discussion_r784277410
##########
File path: cpp/src/arrow/table.cc
##########
@@ -612,7 +612,8 @@ Status
TableBatchReader::ReadNext(std::shared_ptr<RecordBatch>* out) {
}
// Determine the minimum contiguous slice across all columns
- int64_t chunksize = std::min(table_.num_rows(), max_chunksize_);
+ int64_t chunksize =
+ std::min(table_.num_rows() - absolute_row_position_, max_chunksize_);
Review comment:
Basically, this adapts for the "loop remainder"
```c++
// Loop with constant non-unit stride
int64_t absolute_row_position_ = 0;
for (; absolute_row_position_ < table_.num_rows(); absolute_row_position_ +=
max_chunksize_) {
process(max_chunksize_);
}
// Loop remainder
if (absolute_row_position_ < table_.num_rows()) {
process(table_.num_rows() - absolute_row_position_);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
