alamb commented on a change in pull request #1170:
URL: https://github.com/apache/arrow-rs/pull/1170#discussion_r784375825
##########
File path: arrow/src/buffer/immutable.rs
##########
@@ -244,6 +244,7 @@ impl std::ops::Deref for Buffer {
}
unsafe impl Sync for Buffer {}
+#[allow(clippy::non_send_fields_in_send_ty)]
Review comment:
The `unsafe` marker for Buffer worries me (perhaps related to the FFI
deallocator?) -- I will file a ticket to look into it in more detail
In the interim, this code is no more sound/unsound than it was prior to
clippy noticing this problem, so I think it would be ok to merge this PR in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
