lidavidm commented on a change in pull request #11616:
URL: https://github.com/apache/arrow/pull/11616#discussion_r785223779
##########
File path: cpp/src/arrow/ipc/read_write_test.cc
##########
@@ -2908,6 +2910,50 @@ INSTANTIATE_TEST_SUITE_P(PreBufferingTests,
PreBufferingTest,
}
});
+Result<std::shared_ptr<RecordBatch>> MakeBatchWithDictionaries(const int
length) {
+ auto schema_ = ::arrow::schema({::arrow::field("i32", int32()),
+ ::arrow::field("i32d", dictionary(int8(),
int32()))});
+ std::shared_ptr<Array> a0, a1;
+ RETURN_NOT_OK(MakeRandomInt32Array(length, false,
arrow::default_memory_pool(), &a0));
+ RETURN_NOT_OK(MakeRandomInt32Array(length, false,
arrow::default_memory_pool(), &a1));
+ EXPECT_OK_AND_ASSIGN(auto encoded_datum, compute::DictionaryEncode(a1));
Review comment:
I don't think we can depend on compute from IPC, right? We could just
make a random array as the dictionary, then make a random array of indices, and
manually build the dictionary array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
