james727 opened a new pull request #1579: URL: https://github.com/apache/arrow-datafusion/pull/1579
# Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/1323 # What changes are included in this PR? This includes the implementation of `array_agg(distinct ...)`. I also moved `phsyical_plan/distinct_expression.rs` into `physical_plan/expression` - I wanted to reuse a private test utility in `physical_plan/expression`, and it seemed like a more natural location for it anyways. I can move it back if preferred though. # Are there any user-facing changes? This adds net-new functionality. Not sure if any doc updates are needed though. # Input needed I'm interested in any tips on improving the testing approach. It's pretty annoying that the output order is non-deterministic here, and the lack of `ORD` implementation for `ScalarValue` makes a sort + equality check approach difficult as well. I'm new to Rust though so I'm sure there are better ways to structure this than what I've done so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
