alamb commented on a change in pull request #1562:
URL: https://github.com/apache/arrow-datafusion/pull/1562#discussion_r785437868
##########
File path: ballista/rust/core/src/serde/logical_plan/from_proto.rs
##########
@@ -246,8 +246,8 @@ impl TryInto<LogicalPlan> for &protobuf::LogicalPlanNode {
.collect::<Result<Vec<_>, _>>()?,
partition_count as usize,
),
- PartitionMethod::RoundRobin(batch_size) => {
- Partitioning::RoundRobinBatch(batch_size as usize)
+ PartitionMethod::RoundRobin(partition_count) => {
Review comment:
nice find
##########
File path: datafusion/src/datasource/file_format/csv.rs
##########
@@ -178,7 +178,7 @@ mod tests {
async fn read_limit() -> Result<()> {
let runtime = Arc::new(RuntimeEnv::default());
let projection = Some(vec![0, 1, 2, 3]);
- let exec = get_exec("aggregate_test_100.csv", &projection, 1024,
Some(1)).await?;
+ let exec = get_exec("aggregate_test_100.csv", &projection,
Some(1)).await?;
Review comment:
I think the idea of putting `batch_size` on the `RuntimeConfig` is 🏅 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
