Igosuki commented on pull request #1556: URL: https://github.com/apache/arrow-datafusion/pull/1556#issuecomment-1013898492
Yes sorry about that, these were simply comments to Indicate that these particular feature tests were not passing. Le dim. 16 janv. 2022 à 09:52, QP Hou ***@***.***> a écrit : > Thank you everyone for all the reviews and comments so far. @Igosuki > <https://github.com/Igosuki> and I have addressed most of them. Here are > the two remaining todo items: > > - Get the parquet row group filter test to pass > - Restore sql integration test migration. All those sql tests were > migrated and passing previously, but those changes got lost when we merged > the sql test refactoring from master. > > I will keep working on this tomorrow. In the mean time, feel free to send > PRs to my fork if you are interested in helping. After these two items are > fixed, I will run another round of benchmark to double check the > performance fix. It's quite interesting that I got the opposite performance > test result initial even without that file buf fix :P I will dig into > what's causing that as well. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow-datafusion/pull/1556#issuecomment-1013835311>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADDFBSPYHZOIG4O2XOGWZDUWKBLXANCNFSM5L5P5AVQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
