tustvold commented on a change in pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r785501187
##########
File path: parquet/src/column/reader/decoder.rs
##########
@@ -95,11 +95,22 @@ pub trait ColumnValueDecoder {
) -> Result<()>;
/// Set the current data page
+ ///
+ /// - `encoding` - the encoding of the page
+ /// - `data` - a point to the page's uncompressed value data
+ /// - `num_levels` - the number of levels contained within the page, i.e.
values including nulls
+ /// - `num_values` - the number of non-null values contained within the
page (V2 page only)
+ ///
+ /// Note: data encoded with [`Encoding::RLE`] may not know its exact
length, as the final
Review comment:
I wanted to be explicit about this to avoid a resurgence of this style
of bug - https://github.com/apache/arrow-rs/issues/1111
This is a crate-private API, and the necessary null counting dance is
performed by RecordReader, but I wanted to call it out for the avoidance of
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
