liukun4515 commented on a change in pull request #1554:
URL: https://github.com/apache/arrow-datafusion/pull/1554#discussion_r786495477
##########
File path: datafusion/src/physical_plan/coercion_rule/binary_rule.rs
##########
@@ -162,12 +162,141 @@ fn get_comparison_common_decimal_type(
}
}
+// Convert the numeric data type to the decimal data type.
+// Now, we just support the signed integer type and floating-point type.
+fn convert_numeric_type_to_decimal(numeric_type: &DataType) ->
Option<DataType> {
+ match numeric_type {
+ DataType::Int8 => Some(DataType::Decimal(3, 0)),
+ DataType::Int16 => Some(DataType::Decimal(5, 0)),
+ DataType::Int32 => Some(DataType::Decimal(10, 0)),
+ DataType::Int64 => Some(DataType::Decimal(20, 0)),
+ // TODO if we convert the floating-point data to the decimal type, it
maybe overflow.
+ DataType::Float32 => Some(DataType::Decimal(14, 7)),
+ DataType::Float64 => Some(DataType::Decimal(30, 15)),
+ _ => None,
+ }
+}
+
+fn mathematics_numerical_coercion(
Review comment:
@alamb I will extend it in the follow-up pull request and support dict
and `distinct` with decimal.
In the follow-up pull request, I think we can refactor out a common part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
