bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r786497997
##########
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##########
@@ -156,39 +212,52 @@ struct Maximum {
}
};
+// Check if timestamp timezones are comparable (either all are empty or none
is).
+Status CheckCompareTimestamps(const ExecBatch& batch) {
+ if (batch.num_values() > 0) {
+ for (int i = 0; i < batch.num_values() - 1; ++i) {
+ const auto& tsi = checked_cast<const TimestampType&>(*batch[i].type());
+ for (int j = i + 1; j < batch.num_values(); ++j) {
+ const auto& tsj = checked_cast<const TimestampType&>(*batch[j].type());
+ bool invalid_state = tsi.timezone().empty();
+ invalid_state ^= tsj.timezone().empty();
+ if (invalid_state) {
+ return Status::Invalid(
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
