alamb opened a new issue #1200:
URL: https://github.com/apache/arrow-rs/issues/1200


   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   Rationale make it as easier (more ergonomic) to implement array comparison, 
both for DataFusion and other users. See rationale in 
https://github.com/apache/arrow-rs/issues/843
   
   **Describe the solution you'd like**
   The idea would basically be to implement the same thing as @viirya did for 
timestamp types in https://github.com/apache/arrow-rs/pull/1095 but for 
`DecimalArrays` 
   
   That is the following code should not assert and compare the decimal arrays 
element by element: 
   
   ```rust
   let arr1: DecimalArray = ...;
   let arr2: DecimalArray = ...;
   let result = eq_dyn(&arr1, &arr2);
   assert!(result.is_ok())
   ```
   
   
   
   **Describe alternatives you've considered**
   For completeness, we could also add `eq_decimal`, `neq_decimal`, etc as 
well, though I personally think focusing on the dyn kernels would be the 
easiest thing.
   
   
   **Additional context**
   
   @liukun4515 has added kernels in DataFusion here which could be adapted
   
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/expressions/binary.rs#L80-L231
   
   other context:
   I am trying to move datafusion over to using the dyn kernels here: 
https://github.com/apache/arrow-datafusion/pull/1475
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to