iajoiner commented on a change in pull request #9702:
URL: https://github.com/apache/arrow/pull/9702#discussion_r787097726
##########
File path: python/pyarrow/_orc.pyx
##########
@@ -138,18 +411,46 @@ cdef class ORCReader(_Weakrefable):
return pyarrow_wrap_table(sp_table)
+
cdef class ORCWriter(_Weakrefable):
cdef:
- object source
+ object sink
unique_ptr[ORCFileWriter] writer
shared_ptr[COutputStream] rd_handle
- def open(self, object source):
- self.source = source
- get_writer(source, &self.rd_handle)
+ def open(self, object sink, file_version=None,
Review comment:
Done! I agree that this is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
