viirya commented on a change in pull request #1595:
URL: https://github.com/apache/arrow-datafusion/pull/1595#discussion_r787409793
##########
File path: datafusion/src/physical_optimizer/pruning.rs
##########
@@ -421,6 +444,13 @@ impl<'a> PruningExpressionBuilder<'a> {
&self.scalar_expr
}
+ fn scalar_expr_value(&self) -> Result<&ScalarValue> {
Review comment:
Updated.
##########
File path: datafusion/src/physical_optimizer/pruning.rs
##########
@@ -75,6 +77,10 @@ pub trait PruningStatistics {
/// return the number of containers (e.g. row groups) being
/// pruned with these statistics
fn num_containers(&self) -> usize;
+
+ /// return the number of null values for the named column.
+ /// Note: the returned array must contain `num_containers()` rows.
+ fn null_counts(&self, column: &Column) -> Option<ArrayRef>;
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
