tustvold commented on a change in pull request #1596:
URL: https://github.com/apache/arrow-datafusion/pull/1596#discussion_r787466759
##########
File path: datafusion/src/physical_plan/sorts/sort_preserving_merge.rs
##########
@@ -304,6 +303,9 @@ pub(crate) struct SortPreservingMergeStream {
/// An index to uniquely identify the input stream batch
next_batch_index: usize,
+ /// min heap for record comparison
+ min_heap: BinaryHeap<Arc<SortKeyCursor>>,
Review comment:
I agree that storing the cursors twice seems redundant, and necessitates
additional atomics (and memory allocations)... I could be missing something
though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
