pitrou commented on a change in pull request #9702:
URL: https://github.com/apache/arrow/pull/9702#discussion_r787524153
##########
File path: cpp/src/arrow/adapters/orc/adapter.cc
##########
@@ -628,41 +733,86 @@ class ArrowOutputStream : public liborc::OutputStream {
int64_t length_;
};
+Result<liborc::WriterOptions> MakeOrcWriterOptions(
+ arrow::adapters::orc::WriteOptions options) {
+ liborc::WriterOptions orc_options_;
+ orc_options_.setFileVersion(
+ liborc::FileVersion(static_cast<uint32_t>(options.file_version.major()),
+
static_cast<uint32_t>(options.file_version.minor())));
+ orc_options_.setStripeSize(static_cast<uint64_t>(options.stripe_size));
+ orc_options_.setCompressionBlockSize(
+ static_cast<uint64_t>(options.compression_block_size));
+ orc_options_.setCompressionStrategy(static_cast<liborc::CompressionStrategy>(
+ static_cast<int8_t>(options.compression_strategy)));
+
orc_options_.setRowIndexStride(static_cast<uint64_t>(options.row_index_stride));
+ orc_options_.setPaddingTolerance(options.padding_tolerance);
+
orc_options_.setDictionaryKeySizeThreshold(options.dictionary_key_size_threshold);
+ orc_options_.setPaddingTolerance(options.padding_tolerance);
+ std::set<uint64_t> orc_bloom_filter_columns_;
+ std::for_each(options.bloom_filter_columns.begin(),
options.bloom_filter_columns.end(),
+ [&orc_bloom_filter_columns_](const int64_t col) {
+ orc_bloom_filter_columns_.insert(static_cast<uint64_t>(col));
+ });
+ orc_options_.setColumnsUseBloomFilter(orc_bloom_filter_columns_);
Review comment:
Hmm, so what? `orc_bloom_filter_columns_` is a local variable and it
isn't used anymore after this, it's not a problem to move from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
