vibhatha commented on a change in pull request #12110:
URL: https://github.com/apache/arrow/pull/12110#discussion_r788416836
##########
File path: cpp/src/arrow/compute/exec/hash_join_node.cc
##########
@@ -275,30 +275,56 @@ Status HashJoinSchema::ValidateSchemas(JoinType
join_type, const Schema& left_sc
}
std::shared_ptr<Schema> HashJoinSchema::MakeOutputSchema(
- const std::string& left_field_name_prefix,
- const std::string& right_field_name_prefix) {
+ const std::string& left_field_name_suffix,
+ const std::string& right_field_name_suffix) {
std::vector<std::shared_ptr<Field>> fields;
int left_size = proj_maps[0].num_cols(HashJoinProjection::OUTPUT);
int right_size = proj_maps[1].num_cols(HashJoinProjection::OUTPUT);
fields.resize(left_size + right_size);
- for (int i = 0; i < left_size + right_size; ++i) {
- bool is_left = (i < left_size);
- int side = (is_left ? 0 : 1);
- int input_field_id = proj_maps[side]
- .map(HashJoinProjection::OUTPUT,
HashJoinProjection::INPUT)
- .get(is_left ? i : i - left_size);
+ std::unordered_multimap<std::string, int> left_field_map;
Review comment:
Think my comment on multi-column is wrong: multi-columns are supported
as I assumed.
##########
File path: cpp/src/arrow/compute/exec/hash_join_node.cc
##########
@@ -275,30 +275,56 @@ Status HashJoinSchema::ValidateSchemas(JoinType
join_type, const Schema& left_sc
}
std::shared_ptr<Schema> HashJoinSchema::MakeOutputSchema(
- const std::string& left_field_name_prefix,
- const std::string& right_field_name_prefix) {
+ const std::string& left_field_name_suffix,
+ const std::string& right_field_name_suffix) {
std::vector<std::shared_ptr<Field>> fields;
int left_size = proj_maps[0].num_cols(HashJoinProjection::OUTPUT);
int right_size = proj_maps[1].num_cols(HashJoinProjection::OUTPUT);
fields.resize(left_size + right_size);
- for (int i = 0; i < left_size + right_size; ++i) {
- bool is_left = (i < left_size);
- int side = (is_left ? 0 : 1);
- int input_field_id = proj_maps[side]
- .map(HashJoinProjection::OUTPUT,
HashJoinProjection::INPUT)
- .get(is_left ? i : i - left_size);
+ std::unordered_multimap<std::string, int> left_field_map;
Review comment:
Think my comment on multi-column is wrong: multi-columns with same name
are supported as I assumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
