dragosmg commented on a change in pull request #12170:
URL: https://github.com/apache/arrow/pull/12170#discussion_r788696012
##########
File path: r/R/dataset-format.R
##########
@@ -309,14 +309,52 @@ FileWriteOptions <- R6Class("FileWriteOptions",
inherit = ArrowObject,
public = list(
update = function(table, ...) {
+ compose_err_header <- function(unsupported_passed_args) {
+ paste0(
+ oxford_paste(unsupported_passed_args),
+ ngettext(length(unsupported_passed_args),
+ " is not a valid argument ",
+ " are not valid arguments "),
+ "for your chosen `format`."
+ )
+ }
Review comment:
This is slightly more complicated if we want to support type-specific
error bullet points. Normally, I wouldn't be in favour as to me, this function
will then try to do too much. I'll give it a go and see what it looks like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
