rok commented on a change in pull request #12136:
URL: https://github.com/apache/arrow/pull/12136#discussion_r788776860
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal_test.cc
##########
@@ -156,6 +156,24 @@ TEST(TestDispatchBest, CommonTemporal) {
args = {timestamp(TimeUnit::SECOND, "America/Phoenix"),
timestamp(TimeUnit::SECOND, "UTC")};
ASSERT_EQ(nullptr, CommonTemporal(args.data(), args.size()));
+ args = {date32(), duration(TimeUnit::MILLI)};
+ AssertTypeEqual(duration(TimeUnit::MILLI), CommonTemporal(args.data(),
args.size()));
+ args = {date64(), duration(TimeUnit::MICRO)};
+ AssertTypeEqual(duration(TimeUnit::MICRO), CommonTemporal(args.data(),
args.size()));
Review comment:
That falls more into
[ARROW-14095](https://github.com/apache/arrow/pull/12137/files) and here I'm
only doing the minimum to pass test cases. Do you think it makes sense to do
the whole logic at once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
