coryan commented on pull request #12204: URL: https://github.com/apache/arrow/pull/12204#issuecomment-1017573832
> It's a bit convoluted and awkward, as Abseil is only an optional indirect dependency of the GCSFS implementation. Furthermore, since Flatbuffers is vendored, I don't think it has an existence in the dependency graph at all currently (it's basically always there). I see. Consider that (by default) `absl::string_view` is just an alias for `std::string_view` when compiling with C++ >= 17, and it is a template class when compiling with C++ <= 14 (something I do not happen to like but it is a thing: abseil/abseil-cpp#696). I am not sure if Flatbuffers depends on that (my guess would be no), hopefully not. If it did, you may run intro trouble as it tries to use `std::string_view` in C++17 but the Arrow version of `string_view` does not magically convert to `std::string_view`. You may want to just disable the automatic detection of Abseil's string view. Just my $0.02, I think your change should work as-is too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
