bkmgit commented on pull request #11882: URL: https://github.com/apache/arrow/pull/11882#issuecomment-1017900746
> Thanks for doing this. I'm afraid the tests would deserve a lot of cleanup and simplification. Also, the ternary bit-block-counting seems entirely unused, so probably shouldn't be here. > > Can you take a look at the comments below? @pitrou Thanks for the feedback. Have cleaned up the tests and removed ternary bit block count. - To avoid templates, [created a small routine to return the type](https://github.com/apache/arrow/pull/11882#discussion_r789005846) Is there a better way to do this? - Still need to refactor [PhysicalNumeric](https://github.com/apache/arrow/pull/11882#discussion_r786034907), but let me know if any other changes are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
