james727 commented on a change in pull request #1618:
URL: https://github.com/apache/arrow-datafusion/pull/1618#discussion_r790067822
##########
File path: datafusion/tests/sql/joins.rs
##########
@@ -210,6 +210,26 @@ async fn left_join_unbalanced() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn left_join_filter_pushdown() -> Result<()> {
+ // Since t2 is the non-preserved side of the join, we cannot push down a
NULL filter.
Review comment:
I think in this case, we can't even rewrite the join, since `IS NULL` by
definition does not remove nulls. So this should still be valid? I'll try and
clarify a bit in the comment though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
