liukun4515 commented on a change in pull request #1641:
URL: https://github.com/apache/arrow-datafusion/pull/1641#discussion_r790122013
##########
File path: datafusion/src/physical_plan/metrics/value.rs
##########
@@ -401,10 +413,12 @@ impl MetricValue {
match self {
Self::OutputRows(_) => 0, // show first
Self::ElapsedCompute(_) => 1, // show second
- Self::Count { .. } => 2,
- Self::Time { .. } => 3,
- Self::StartTimestamp(_) => 4, // show timestamps last
- Self::EndTimestamp(_) => 5,
+ Self::SpillCount(_) => 2,
+ Self::SpilledBytes(_) => 3,
+ Self::Count { .. } => 4,
Review comment:
It looks good to me, but we can make the format consistent with others
as a minor fix in a follow-up pull request.
`Self::Count { .. } => 4,` -> `Self::Count(_) => 4,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
