alamb opened a new pull request #1645: URL: https://github.com/apache/arrow-datafusion/pull/1645
Builds on https://github.com/apache/arrow-datafusion/pull/1643, so draft until that is merged # Which issue does this PR close? closes https://github.com/apache/arrow-datafusion/issues/1644 # Rationale for this change The way to convert `DataFusionError` into an `ArrowError` is confusing for Rust programmers coming to the DataFusion codebase and makes our codebase a bit of a mess ``` DataFusionError::into_arrow_external_error ``` They typically expect a `impl From<..>` conversion trait # What changes are included in this PR? 1. remove `DataFusionError::into_arrow_external_error` 2. Update code to use `From` impl instead # Are there any user-facing changes? Nicer error handling, but removal of `into_arrow_external_error` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
