jhorstmann opened a new pull request #1221:
URL: https://github.com/apache/arrow-rs/pull/1221


   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Removes explicit simd arithmetic kernels, except for division/modulo, as 
compiler autovectorization actually generates better code. Also adds a new 
`divide_unchecked` kernel for floating point division, which does not need to 
return an error for division by zero. [Benchmark results on my 
laptop](https://github.com/apache/arrow-rs/issues/1182#issuecomment-1013669825)
   
   Closes #1182.
   
   # Rationale for this change
    
   Simplifies the code and increases performance at the same time.
    
   # What changes are included in this PR?
   
   <!---
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   No. `ArrowFloatNumericType::pow` is now unused though and could be removed. 
The trait should be kept since some kernels might make only sense on floating 
point data.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to