liukun4515 commented on a change in pull request #1659:
URL: https://github.com/apache/arrow-datafusion/pull/1659#discussion_r790440577



##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -1179,9 +1179,21 @@ message ScalarValue{
         ScalarType null_list_value = 18;
 
         PrimitiveScalarType null_value = 19;
+        Decimal128 decimal128_value = 20;
+        int64 date_64_value = 21;
+        int64 time_second_value = 22;
+        int64 time_millisecond_value = 23;
+        int32 interval_yearmonth_value = 24;
+        int64 interval_daytime_value = 25;
     }
 }
 
+message Decimal128{
+  string value = 1;

Review comment:
       I'm confused about this point, we use the `String` type to hold the 
value of Decimal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to