paleolimbot commented on a change in pull request #12208:
URL: https://github.com/apache/arrow/pull/12208#discussion_r791642605
##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -173,3 +173,31 @@ test_that("mutate then join", {
)
)
})
+
+test_that("filter then join", {
Review comment:
Could you give this a slightly longer label? I'm not sure based on the
title and content of the test what it is testing (without chasing the JIRAs
back to the source).
##########
File path: r/tests/testthat/test-dplyr-join.R
##########
@@ -173,3 +173,31 @@ test_that("mutate then join", {
)
)
})
+
+test_that("filter then join", {
Review comment:
I'm with you, but while we're here it's worth a few extra words to help
out future us when this test fails. How about `test_that("arrow dplyr query
correctly filters + joins", ...`? I agree that the original ticket isn't very
descriptive...whenever this is the case I try to add some extra text in the PR
to give reviewers somewhere to start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
