jonkeane commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r792955474
##########
File path: r/R/array.R
##########
@@ -188,6 +188,11 @@ Array$create <- function(x, type = NULL) {
return(out)
}
+ if (inherits(x, "POSIXct") && attr(x, "tzone") == "") {
+ attr(x, "tzone") <- Sys.timezone()
Review comment:
It looks to me like it's still an unmarked, but still definitely zoned
timestamp:
```
> a <- strptime("2020-01-01", format = "%Y-%m-%d") + 1
> a
[1] "2020-01-01 00:00:01 CST"
> as.integer(a)
[1] 1577858401
```
If it was truly naive it should (1) not display the timezone in the print
method) and (2) converting it to an integer is undefined (since you don't know
how to go from the timestamp details to the epoch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
