kou commented on a change in pull request #12271: URL: https://github.com/apache/arrow/pull/12271#discussion_r793183358
########## File path: c_glib/test/test-utf8-normalize-options.rb ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +class TestUtf8NormalizeOptions < Test::Unit::TestCase Review comment: ```suggestion class TestUTF8NormalizeOptions < Test::Unit::TestCase ``` ########## File path: c_glib/test/test-utf8-normalize-options.rb ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +class TestUtf8NormalizeOptions < Test::Unit::TestCase + include Helper::Buildable + + def setup + @options = Arrow::Utf8NormalizeOptions.new + end + + def test_mode Review comment: ```suggestion def test_form ``` ########## File path: c_glib/arrow-glib/compute.h ########## @@ -675,6 +675,40 @@ GArrowRoundToMultipleOptions * garrow_round_to_multiple_options_new(void); +/** + * GArrowUtf8NormalizeForm: Review comment: Could you use `UTF` not `Utf`? We don't want to capitalize acronym such as HTTP and CSV. ```suggestion * GArrowUtf8NormalizeForm: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
