pitrou commented on a change in pull request #12198:
URL: https://github.com/apache/arrow/pull/12198#discussion_r793738446
##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1618,10 +1614,13 @@ def _temp_path():
.skip_category('Go')
.skip_category('JS'),
- # TODO(ARROW-3039, ARROW-5267): Dictionaries in GO
generate_dictionary_case()
.skip_category('C#')
- .skip_category('Go'),
+ # TODO(ARROW-3039, ARROW-5267): Dictionaries in GO
+ .skip_category('Go')
+ # TODO: JavaScript does not support uint64 dictionary indices, so
disabled
+ # for now
+ .skip_category("JS"),
Review comment:
Isn't it `generate_dictionary_unsigned_case` that should be skipped
instead?
##########
File path: dev/archery/archery/integration/datagen.py
##########
@@ -1401,9 +1401,8 @@ def generate_nested_case():
get_field('item', 'int32'), 4),
StructField('struct_nullable', [get_field('f1', 'int32'),
get_field('f2', 'utf8')]),
- # Fails on Go (ARROW-8452)
- # ListField('list_nonnullable', get_field('item', 'int32'),
- # nullable=False),
+ ListField('list_nonnullable', get_field('item', 'int32'),
+ nullable=False),
Review comment:
Perhaps make a separate `generate_non_nullable_list_case` so that other
nested cases can still be checked on Go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
