westonpace commented on a change in pull request #12160:
URL: https://github.com/apache/arrow/pull/12160#discussion_r794182177
##########
File path: cpp/src/arrow/ipc/options.h
##########
@@ -87,9 +87,9 @@ struct ARROW_EXPORT IpcWriteOptions {
/// \brief Whether to unify dictionaries for the IPC file format
///
- /// The IPC file format doesn't support dictionary replacements or deltas.
+ /// The IPC file format doesn't support dictionary replacements.
/// Therefore, chunks of a column with a dictionary type must have the same
- /// dictionary in each record batch.
+ /// dictionary in each record batch (or an extended dictionary + delta).
///
/// If this option is true, RecordBatchWriter::WriteTable will attempt
/// to unify dictionaries across each table column. If this option is
Review comment:
I changed from unequal to incompatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
