emkornfield edited a comment on pull request #12216: URL: https://github.com/apache/arrow/pull/12216#issuecomment-1023871928
> If we instead passed the (correct?) length of 2560 bits, then the problematic write on this line will not happen: Realized I was saying the same thing. I think this is correct, nice catch. If this is more then an off-by overwrite error I think there might be deeper problems. Just need to think about if it is an error in the Levels to Bitmap function that is writing when it shouldn't be or somehow we are getting the math wrong, passing down the wrong number for passing the upper bound on values. But i do think https://github.com/apache/arrow/blob/b1ae6029687aa3bb756c61a189c88125128cf026/cpp/src/parquet/level_conversion_inc.h#L336 should be taking values_read_upper_bound instead of num_def_levels. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
