yjshen commented on a change in pull request #1691:
URL: https://github.com/apache/arrow-datafusion/pull/1691#discussion_r794407926
##########
File path: datafusion/src/physical_plan/sorts/sort.rs
##########
@@ -139,41 +143,43 @@ impl ExternalSorter {
let stream = read_spill_as_stream(spill, self.schema.clone())?;
streams.push(SortedStream::new(stream, 0));
}
- let baseline_metrics = self.metrics.new_final_baseline(partition);
+ let tracking_metrics = self
+ .metrics_set
+ .new_final_tracking(partition, self.runtime.clone());
Ok(Box::pin(SortPreservingMergeStream::new_from_streams(
streams,
self.schema.clone(),
&self.expr,
- baseline_metrics,
- partition,
+ tracking_metrics,
self.runtime.clone(),
)))
} else if in_mem_batches.len() > 0 {
- let baseline_metrics = self.metrics.new_final_baseline(partition);
+ let tracking_metrics = self
+ .metrics_set
+ .new_final_tracking(partition, self.runtime.clone());
let result = in_mem_partial_sort(
&mut *in_mem_batches,
self.schema.clone(),
&self.expr,
- baseline_metrics,
+ tracking_metrics,
);
- self.inner_metrics.mem_used().set(0);
- // TODO: the result size is not tracked
Review comment:
This is the reason I wrote this PR in the first place 🤔. A large sorted
record batch whose memory is not tracked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
