jonkeane commented on a change in pull request #12170:
URL: https://github.com/apache/arrow/pull/12170#discussion_r791867264
##########
File path: r/R/dataset-format.R
##########
@@ -309,14 +309,57 @@ FileWriteOptions <- R6Class("FileWriteOptions",
inherit = ArrowObject,
public = list(
update = function(table, ...) {
+ check_additional_args <- function(format, passed_args) {
+ if (format == "parquet") {
+ supported_args <- names(formals(write_parquet))
+ supported_args <- supported_args[supported_args != c("x", "sink")]
+ } else if (format == "ipc") {
+ supported_args <- c(
+ "use_legacy_format",
+ "metadata_version",
+ "codec",
+ "null_fallback"
+ )
+ } else if (format == "csv") {
+ supported_args <- names(formals(CsvWriteOptions$create))
+ }
+
+ unsupported_passed_args <- setdiff(passed_args, supported_args)
+
+ if (length(unsupported_passed_args) > 0) {
+ err_header <- paste0(
+ oxford_paste(unsupported_passed_args, quote_symbol = "`"),
+ ngettext(length(unsupported_passed_args),
+ " is not a valid argument ",
+ " are not valid arguments "),
+ "for your chosen `format`."
+ )
+ err_info <- NULL
+ arg_info <- paste0(
+ "Supported arguments: ",
+ oxford_paste(supported_args, quote_symbol = "`"),
+ "."
+ )
+ if ("compression" %in% unsupported_passed_args) {
+ err_info <- "You could try using `codec` instead of `compression`."
+ }
+ abort(c(err_header, i = err_info, i = arg_info))
+ }
+ }
+
if (self$type == "parquet") {
+ args <- list(...)
+ check_additional_args(self$type, names(args))
Review comment:
I _think_ these two lines could actually go up outside of this `if` and
only be called once. It's only a (tiny) amount of repetition, but nice to be
DRY. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
